qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Published 20 hours ago • verified publisher icon qmk

[Keyboard] Add FancyAlice66

Open z-ww447 opened this issue 2 years ago • 3 comments

Added FancyAlice66 by Fancytech, with optional rotary encoder slot.

Description

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [ ] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

z-ww447 avatar Jun 28 '22 14:06 z-ww447

I've removed the extra keymaps and added encoder support to kb.c as requested. I've managed to keep the encoder support for via, please let me know if that's acceptable

z-ww447 avatar Jul 03 '22 12:07 z-ww447

Please let me know if my implementation is acceptable

z-ww447 avatar Jul 04 '22 15:07 z-ww447

@fauxpark can you review the changes please

z-ww447 avatar Jul 25 '22 15:07 z-ww447

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Nov 15 '22 02:11 github-actions[bot]

Thank you for your contribution! This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. // [stale-action-closed]

github-actions[bot] avatar Dec 16 '22 01:12 github-actions[bot]

@chent7 any chance of openning another pull request? probably the maintainers didnt have time to review previosly, so it was automatically closed

ogabriel avatar Apr 30 '23 15:04 ogabriel

@chent7 any chance of openning another pull request? probably the maintainers didnt have time to review previosly, so it was automatically closed

I didn't have time to continue working on the new changes. But feel free to continue with new PR if you would like to work on it.

z-ww447 avatar Apr 30 '23 15:04 z-ww447