qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Published 20 hours ago • verified publisher icon qmk

[Keyboard] Add Hillside 52

Open mmccoyd opened this issue 2 years ago • 2 comments

Description

Add Hillside 52 with default.json .c and via keymaps. https://github.com/mmccoyd/hillside

The handwired/hillside/readme has a link to where the 48 keyboard will be once approved PR #17210, renaming Hillside 0_1 to Hillside 48, is merged. Until then it is a broken link.

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [ ] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

mmccoyd avatar Jun 13 '22 02:06 mmccoyd

Sorry I missed that.

mmccoyd avatar Jul 02 '22 21:07 mmccoyd

Keymap has caps word on a layer. Rebase to master HEAD. Also checked convert to 2040 over on dev.

mmccoyd avatar Jul 15 '22 19:07 mmccoyd

Any particular reason this in in handwired

keyboard-magpie avatar Aug 07 '22 19:08 keyboard-magpie

My reading of QMK guidelines was that boards not in commercial production went in handwired. Whether they were PCB or actually handwired. So I put the original hillside there.

mmccoyd avatar Aug 08 '22 20:08 mmccoyd

My reading of QMK guidelines was that boards not in commercial production went in handwired. Whether they were PCB or actually handwired. So I put the original hillside there.

This is fairly old dogma, nowadays any keyboard with a PCB is welcome in the main repository- will leave this for now but could be a future PR for you.

keyboard-magpie avatar Aug 13 '22 16:08 keyboard-magpie

Thanks for the review! Once they all settle I'll do a PR to move up out of handwired.

mmccoyd avatar Aug 13 '22 16:08 mmccoyd

This is fairly old dogma, nowadays any keyboard with a PCB is welcome in the main repository- will leave this for now but could be a future PR for you.

Would setting up a move PR now be less disruptive? There are still two hillside PRs in flight. A merged to dev breaking change rename of 0_1 to 48, and an addition of Hillside 46. My guess is that after those complete would be best.

mmccoyd avatar Aug 13 '22 16:08 mmccoyd

Would suggest after this current/impending breaking changes cycle.

keyboard-magpie avatar Aug 13 '22 18:08 keyboard-magpie