[Keyboard] Add darkproject/kd83a_bfg_edition

[gskygithub]

Description

Add darkproject/kd83a_bfg_edition keyboard.

Types of Changes

• [ ] Core
• [ ] Bugfix
• [ ] New feature
• [ ] Enhancement/optimization
• Keyboard (addition or update)
• [ ] Keymap/layout/userspace (addition or update)
• [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes.
• [ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[drashna]

Are any of the files in the "src" folder actually needed, or are they just copy-pasted from another board/project?

[gskygithub]

Are any of the files in the "src" folder actually needed, or are they just copy-pasted from another board/project?

Files in "src" folder are necessary because those files are related to flash, without those files we can not save any function in keyboard.

[drashna]

Maybe, but it looks like the wb32_spi_master.c is a duplicate of platforms/chibios/drivers/spi_master.c, with the non-wb32 contents removed. the flash_spi.c looks to be byte for byte identical to drivers/flash/flash_spi.c

Adding these files separately introduce redundant files.

Any and all duplicate files like this should be removed.

The only unique file there appears to be the eeprom_flash.c file.

[gskygithub]

Tested, only eeprom_flash.c file is saving function in keyboard.

[gskygithub]

Maybe, but it looks like the wb32_spi_master.c is a duplicate of platforms/chibios/drivers/spi_master.c, with the non-wb32 contents removed. the flash_spi.c looks to be byte for byte identical to drivers/flash/flash_spi.c

Adding these files separately introduce redundant files.

Any and all duplicate files like this should be removed.

The only unique file there appears to be the eeprom_flash.c file.

Changes are done. Could you please refer to it. If anything else are needed. @drashna

[gskygithub]

Is there anything else I could fix @fauxpark @zvecr ? Would be glad to help.

[tzarc]

@gksygithub gksygithub requested a review from tzarc

Items are still unaddressed.

[gskygithub]

@gksygithub gksygithub requested a review from tzarc

Items are still unaddressed.

May I know what are those.

[gskygithub]

@gksygithub gksygithub requested a review from tzarc

Items are still unaddressed.

May I know what are those.

@tzarc Could you please help me out.

[gskygithub]

@fauxpark Could you please review the resolved changes and let me know If there is anything need to change. Thanks

[gskygithub]

Sorry for tagging you again, @fauxpark @tzarc @zvecr. I would be really glad to help if there is something to resolve this pull request.

[gskygithub]

@gksygithub gksygithub requested a review from tzarc

Items are still unaddressed.

Resolved, Could you please review. @tzarc

[gskygithub]

Can anyone review this pull request please.

[gskygithub]

Could someone help to review the changes please.

[gskygithub]

Can someone please take a look at this pull request, Is there anything else I could fix? Would be glad to help.