Keychron q3

[KeychronMacro]

Add new keyboard q3 which contains six sub versions.

Description

• Add keyboard rev_0120, ansi version of q3.
• Add keyboard rev_0120_lhg, ansi version of q3.
• Add keyboard rev_0121, ansi version of q3 and enable encoder ec11.
• Add keyboard rev_0122, iso version of q3.
• Add keyboard rev_0123, iso version of q3 and enable encoder ec11.
• Add keyboard rev_0124, jis version of q3.
• Add keyboard rev_0125, jis version of q3 and enable encoder ec11.

Types of Changes

• [ ] Core
• [ ] Bugfix
• [ ] New feature
• [ ] Enhancement/optimization
• [x] Keyboard (addition or update)
• [x] Keymap/layout/userspace (addition or update)
• [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

• [x] My code follows the code style of this project: C, Python
• [x] I have read the PR Checklist document and have made the appropriate changes.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [x] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes.
• [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[zvecr]

To allow this PR to be reviewed faster, please remove all q1 changes from this PR.

[IBNobody]

The keychron-q3 branch still has the bug with the EC11 encoder missing codes due to the custom matrix and RGB Matrix code slowing down the matrix scan rate.

[KeychronMacro]

Restore accidently deleted branch.

[lokher]

The keychron-q3 branch still has the bug with the EC11 encoder missing codes due to the custom matrix and RGB Matrix code slowing down the matrix scan rate.

Please refer to PR #16954

[chevdor]

Is this PR being closed due to the lack of review ?

[KeychronMacro]

Hi, In fact, it is not entirely for this reason. We plan to submit the code of q3 again when the relevant code about WL EEPROM driver #16016 is merged into the master branch.

[Blackclaws]

@LALALAdemaxiya #16016 is in master by now, is there any reason not to reopen this PR? I just got the Q3 and it would be nice to have it in the main QMK repo

[LALALAdemaxiya]

这是来自QQ邮箱的自动回复邮件。   您好，我已收到你的信件，我将尽快查阅，感谢你。    

[KeychronMacro]

@Blackclaws Sorry, I may have mistaken the request(https://github.com/qmk/qmk_firmware/pull/16016) and in fact, the WL EEPROM driver(#17376) is not supported in master branch.

[kharenis]

Sorry, I may have mistaken the request(#16016) and in fact, the WL EEPROM driver(#17376) is not supported in master branch.

@lalalademaxiya1 What else is required to get the branch merged into master?

[sharpenedblade]

So on August 28 this PR can hopefully be reopened (and merged, as it is not a breaking change.)

[ntdef]

hey — just checking in because I'd really like to see this change go through. What's significant about August 28th that would allow this to get merged?

[sharpenedblade]

The changes required to merge this have been merged into the develop branch, this needs to be merged into the master branch. That means the develop branch has to merged into master, but it has breaking changes, so it only happens on certain dates, the next one is on 2022-08-27. Read https://docs.qmk.fm/#/breaking_changes for more information.

[ntdef]

The changes required to merge this have been merged into the develop branch, this needs to be merged into the master branch. That means the develop branch has to merged into master, but it has breaking changes, so it only happens on certain dates, the next one is on 2022-08-27. Read https://docs.qmk.fm/#/breaking_changes for more information.

Ah gotcha! Thank you for the extra context.

[kharenis]

@sharpenedblade Thanks for the info :)

[sharpenedblade]

@sharpenedblade Thanks for the info :)

Not to be rude, but please dont mention somebody with a real (very important) reason, it clutters up their already full inbox.

[sharpenedblade]

@lalalademaxiya1 The develop branch was just merged into master, so all the changes needed for this are merged. Can you reopen this pr.

[ntdef]

Any chance we can get this merged now?

[ernestoittig]

@whyudothis5656

Is it possible to program the Q3 per key rgb lighting or is that something that hasnt actually been released yet?

Yes and no. The firmware for the Q3 has not yet been merged to the QMK repo, this is what this PR is for. However, it exists, and if you were to pull from the keychron-q3 branch in Keychron's fork, you could create your own keymap and use QMK's own functions for RGB matrix (see docs). Or just use VIA, with the limitations that come with it.

When/if this PR merges you should be able to do this without all the different forks by just staying up to date with master. For more info about git see the docs.

And finally, I'd advise against asking these sort of questions on PRs, as contributors are very efficient and keen on getting their PRs merged, so it is unlikely they will give you a good answer. I'd say looking for help from other users in a related issue would be more appropriate.

[ScuttleSE]

Why is this PR taking so long to get merged?

[LALALAdemaxiya]

这是来自QQ邮箱的自动回复邮件。   您好，我已收到你的信件，我将尽快查阅，感谢你。    

[adophoxia]

While most of the changes done need to be done on future Q boards, will they also be necessary for boards already in the repo like the Q1v1 and Q2?

[KeychronMacro]

@adophoxia Sure, we will post new PR in the near future.