qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Published 20 hours ago • verified publisher icon qmk

[keymap] Massdrop CTRL keymap - jmrt

Open Jamminroot opened this issue 2 years ago • 5 comments

Description

New keymap which I ended up after messing up with aready existing keymaps. Base keymap used is Matthewrobo, and only change is led animation.

Not sure about header in files - I basically just ran search & replace in a folder, please let me know if that's inappropriate. I did mention in a readme about a source though.

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [ ] Keyboard (addition or update)
  • [x] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Jamminroot avatar Jan 11 '22 22:01 Jamminroot

Aside from applying suggestionos, I've added demo video. Please re-review

Jamminroot avatar Jan 14 '22 01:01 Jamminroot

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

stale[bot] avatar Apr 16 '22 08:04 stale[bot]

Just in case - I'd like to adjust labels, but I couldn't)

Jamminroot avatar Apr 17 '22 05:04 Jamminroot

Done

Jamminroot avatar Apr 19 '22 15:04 Jamminroot

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Jul 14 '22 02:07 github-actions[bot]

Thank you for your contribution! This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. // [stale-action-closed]

zvecr avatar Aug 15 '22 00:08 zvecr

Ironically, it doesn't look like it lacked activity from my side, but rather, yours. Anyways, I'm not missing anything. Have a nice day

Jamminroot avatar Aug 15 '22 10:08 Jamminroot