Quincey Koziol

Results 79 comments of Quincey Koziol

> > ``` > > * Add the fuzzing guards on the complex datatype's encoding. > > ``` > > The previous comment was made in the decode helper routine....

> Most of the major previous comments should be addressed now. I haven't made the change to `H5Tset_size` yet as I still feel fairly strongly about that and I don't...

I can iterate on this with you to get to a better pattern. What is the failure you are attempting to address?

> I can iterate on this with you to get to a better pattern. What is the failure you are attempting to address? @mattjala - I traced this around a...

> > @mattjala - I traced this around a little more today and have some ideas. Would you like to set up a call to talk about it? > >...

Unfortunately, I can't switch H5VL_native_register() from FUNC_ENTER_NOAPI to FUNC_ENTER_API without changing its name (to H5VLnative_register), which I'm pretty reluctant to do. I'll look into some other ways to solve this.

Yes, that's correct, the can_apply method can return three values: can_apply)(dcpl_id, type_id, space_id); } H5_AFTER_USER_CB(FAIL) /* Indicate error during filter callback */ if (status < 0) HGOTO_ERROR(H5E_PLINE, H5E_CANAPPLY, FAIL, "error...

Agree that the reserved filter ID value hasn't changed from 256, as intended. The range of 0-255 are reserved for internal use by the HDF5 library, the range of 256-32767...

Can I please get some reviews on this? @fortnern @mattjala @jhendersonHDF @derobins

I have been waiting for the CMake builds to stabilize, which I believe we're at. I'll update this to resolve the conflicts this week.