vscode-plantuml icon indicating copy to clipboard operation
vscode-plantuml copied to clipboard

`!include` fails if the path of the included file contains a Japanese character

Open shunichironomura opened this issue 2 years ago • 0 comments

Description

  • !include statement seems to fail if the path of the included file contains a Japanese character.
  • It doesn't fail if I directly execute the command-line, i.e., java -jar path/to/plantuml.jar .\あ\d2.pu -I.\あ\d1.pu.
  • See below for some test cases.

Versions

  • PlantUML extension version: v2.17.2
  • Output of java -jar path/to/plantuml.jar -version:
PlantUML version 1.2022.3 (Wed Mar 30 01:10:57 JST 2022)
(GPL source distribution)
Java Runtime: Java(TM) SE Runtime Environment
JVM: Java HotSpot(TM) Client VM
Default Encoding: Cp1252
Language: en
Country: US

PLANTUML_LIMIT_SIZE: 4096

Dot version: dot - graphviz version 2.44.1 (20200629.0846)
Installation seems OK. File generation OK

File contents

d1.pu (The included file)

@startuml
interface List
List : int size()
List : void clear()
List <|.. ArrayList
@enduml

d2.pu (Includes d1.pu)

@startuml
!include d1.pu
@enduml

Cases

Case 1 (Failure)

  • The project folder path contains a Japanese character.
  • "PlantUml: Preview Current Diagram" is executed with d2.pu being active.
  • The folder structure:
Project Folder/
  d1.pu
  d2.pu

Case 2 (Failure)

  • Only the path of the included file (d1.pu) contains a Japanese character.
  • The project folder path only contains English letters.
  • plantuml.diagramsRoot is set to "あ".
  • "PlantUml: Preview Current Diagram" is executed with d2.pu being active.
  • The folder structure:
Project Folder/
  あ/
    d1.pu
  src/
    d2.pu

Case 3 (Success)

  • Only the path of d2.pu contains a Japanese character.
  • The project folder path only contains English letters.
  • plantuml.diagramsRoot is set to "src".
  • "PlantUml: Preview Current Diagram" is executed with d2.pu being active.
  • The folder structure:
Project Folder/
  src/
    d1.pu
  あ/
    d2.pu

shunichironomura avatar Apr 07 '22 03:04 shunichironomura