Yanjun Qi / Jane

Results 21 comments of Yanjun Qi / Jane

@Opdoop yes.. plan to work on that! Can you help?

Mind to submit a PR? Seems super minor.. so easy to mergeOn Dec 13, 2023, at 06:28, Andy ***@***.***> wrote: Any update? All that's required is a minor adjustment to...

@yangheng95 mind to add some unit tests / also please solve conflicts / and locally run "make test"

@yangheng95 do you mind to also add a Jupyter notebook under doc/2notebook to give good examples of your newly added features? Thanks..

@jinyongyoo mind to take a look?

Sorry for the delay.. will take a careful look PR #747 , added a max length constraint in # search_method = GreedyWordSwapWIR(wir_method="gradient") max_len = getattr(model_wrapper, "max_length", None) or min( 1024,...

Please feel free to submit a PR to fix this..Sent from my iPhoneOn Apr 25, 2024, at 12:16, JanCe ***@***.***> wrote: In the GreedyWordSwapWIR class from the PR here, I...

Will take a look

@jakegrigsby can you check this?

@Hanyu-Liu-123 mind to review this?