qiskit-textbook icon indicating copy to clipboard operation
qiskit-textbook copied to clipboard

Added other Bell's state in the entanglement section

Open rochisha0 opened this issue 3 years ago • 5 comments

Fixes #708

Changes made

Added other Bell's state in the entanglement section

Justification

The textbook lacked the introduction of other Bell's state.

rochisha0 avatar Sep 02 '20 16:09 rochisha0

@frankharkins Can you please review the PR?

rochisha0 avatar Sep 19 '20 08:09 rochisha0

@rochisha0 from what I understand, we are including this for completeness so that the reader is aware of the other Bell states. If this is the case, do you think this would be better as a footnote or link (e.g. https://en.wikipedia.org/wiki/Bell_state#Bell_states or something in the appendix)? At the moment it feels a bit disconnected in the flow of the page as @3yakuya mentioned above.

frankharkins avatar Sep 21 '20 15:09 frankharkins

@rochisha0 do you have any thoughts on my comment above?

frankharkins avatar Oct 01 '20 10:10 frankharkins

Hi! @frankharkins Sorry, somehow, I missed your above comment. According to me, it looks fine. I think introducing all 4 Bell's state is pretty important within the section.

rochisha0 avatar Oct 01 '20 11:10 rochisha0

This PR is having some conflicts. Can you resolve that?

divshacker avatar Oct 13 '21 15:10 divshacker

Thanks for your contribution. I'm closing this pull request as this repository is no longer used and is being archived. You can find the latest version of the Qiskit Textbook online at https://qiskit.org/learn/, and the new content repository at Qiskit/textbook. Please feel free to re-open this pull request there if it's still relevant.

frankharkins avatar May 30 '23 12:05 frankharkins