qiskit-textbook icon indicating copy to clipboard operation
qiskit-textbook copied to clipboard

[5.5] Fix the extra ')'

Open devilkiller-ag opened this issue 2 years ago • 2 comments

Changes made

Changed the link to trace on wikipedia in section Trace and Positivity Conditions to eliminate extra ')'.

Justification

There is an extra ')' after the link to wikipedia which needs to be eliminated. It was due to '(' and ')' in the link to wikipedia. I encoded them with '%28' for '(' and '%29' for '('.

devilkiller-ag avatar Sep 24 '22 14:09 devilkiller-ag

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ashmit JaiSarita Gupta seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 24 '22 14:09 CLAassistant

Can someone please review my PR? @nkanazawa1989 @kifumi @kUmezawa @vabarbosa @HwajungKang @frankharkins

devilkiller-ag avatar Oct 05 '22 18:10 devilkiller-ag

@devilkiller-ag sorry, I can't see any changes, looks like something strange happened to your fork 😕

frankharkins avatar Oct 06 '22 22:10 frankharkins

Kindly review the changes now. Sorry for the inconvenience before.

devilkiller-ag avatar Oct 08 '22 12:10 devilkiller-ag

Hi, sorry but you've now removed 22,000 lines and the diff is too large to show on GitHub; can you reset the notebook and make the change again?

frankharkins avatar Oct 10 '22 16:10 frankharkins

Sure @frankharkins

devilkiller-ag avatar Oct 11 '22 05:10 devilkiller-ag

I am closing this PR and making a new PR for this. Kindly check that PR. Sorry for the inconveniences.

devilkiller-ag avatar Oct 11 '22 06:10 devilkiller-ag