qiskit-textbook icon indicating copy to clipboard operation
qiskit-textbook copied to clipboard

Changing shebang in `build` and `deploy` scripts for better portability

Open paniash opened this issue 3 years ago • 4 comments

Changes made

Changed shebang in build.sh from #!/bin/bash to #!/usr/bin/env bash.

Justification

In build.sh, the bash interpreter path is provided as #!/bin/bash, which is good but only for specific systems (*nix). In other systems, this path might not be where bash exists and a reasonable shebang would be #!/usr/bin/env bash, which is much more portable. Please refer this to learn more.

paniash avatar Jun 08 '21 14:06 paniash

Have you tested this on other systems? @paniash

divshacker avatar Oct 18 '21 06:10 divshacker

Explicitly no. But I see no reason why it shouldn't work. :-)

paniash avatar Oct 18 '21 09:10 paniash

@frankharkins What do you think ?

divshacker avatar Oct 18 '21 09:10 divshacker

Really need @vabarbosa to look over.

frankharkins avatar Oct 18 '21 10:10 frankharkins