qiskit-nature icon indicating copy to clipboard operation
qiskit-nature copied to clipboard

Implement Transformers

Open manoelmarques opened this issue 4 years ago • 3 comments

Migrated from Enterprise Github. Creator: @mrossinek

The state of the SecondQuantizedSumOp-Transformations is the following:

  • [ ] Implementation
    • [ ] SeniorityZeroTransformation
    • [x] FreezeCoreTransformation
    • [x] ActiveSpaceTransformation
    • [ ] ParticleHoleTransformation
    • ~TranscorrelatedTransformation~
  • [ ] Unittests
    • [ ] SeniorityZeroTransformation
    • [x] FreezeCoreTransformation
    • [x] ActiveSpaceTransformation
    • [ ] ParticleHoleTransformation
    • ~TranscorrelatedTransformation~

Note: this issue may be broken down into several issues as work starts to progress.

manoelmarques avatar Jan 28 '21 20:01 manoelmarques

We actually need to implement these transformers before the SecondQuantizedOp is being created. The reason is that in the process of this creation multiple integral coefficients will map to identical ParticleOp.labels and, therefore, a compression (or loss) of information occurs. However, all of the Transformers mentioned above rely on the complete set of raw information (up-to-now mostly integrals) to be available. Therefore, the interface has been adapted to accomodate this as follows: screenshot_1612461565

A note on the OrderingRules: these may be used to prevent misordered application of multiple transformers. One possible source of error is shifting of integral indices after one Transformer has been applied. While this can be mitigated by storing a map of orbital indices, other Transformers may just straight up be incompatible. This can also be encoded in this rule set.

mrossinek avatar Feb 04 '21 18:02 mrossinek

All transformers which will be part of the upcoming release are finished. The remaining ones will be tracked in their own issues:

  • SeniorityZero: #46
  • ParticleHole: #48

Thus, I am closing this broader issue in favor of these other ones.

mrossinek avatar Mar 31 '21 14:03 mrossinek

Converting this to an Epic for the planning of the upcoming release.

mrossinek avatar Apr 21 '21 09:04 mrossinek

I am closing this Epic in favor of keeping the two separate issues that are left from this: #46 and #48. Since both of these transformers are fairly low in priority, there is no plan to implement them within a scheduled sprint so I would rather close this and leave the separate transformer issues as "up for grabs" (in fact one of them already has a WIP PR).

mrossinek avatar Apr 12 '23 14:04 mrossinek