qiskit-machine-learning icon indicating copy to clipboard operation
qiskit-machine-learning copied to clipboard

Add more classifier

Open poig opened this issue 2 years ago • 6 comments

What should we add?

we should include more classifiers:

  • [ ] Quantum K-NN has already been done, but only fit the old version. https://github.com/GroenteLepel/qiskit-quantum-knn
  • [ ] Quantum Random Forest Classifier https://arxiv.org/pdf/2210.02355.pdf https://github.com/maiyuren/Quantum-Random-Forest

Maybe we should add these also:

  • [ ] Quantum GaussianNB
  • [ ] Quantum DecisionTreeClassifier

poig avatar Oct 18 '22 18:10 poig

There's this project implementing other quantum classification and regression methods : https://github.com/mspronesti/qlearnkit

chin-jey avatar Oct 20 '22 18:10 chin-jey

Yeah, thanks for the share, it includes QKmeans, Qridge, QSVM K-NN, regression, dataset, encoding map, swaptest circuit, but it's not fit the latest qiskit version.

poig avatar Oct 21 '22 03:10 poig

Why not ? It seems it does to me.

chin-jey avatar Oct 21 '22 08:10 chin-jey

Why not ? It seems it does to me.

thanks, I just see that it fit with the sources code, but not the latest release version.

poig avatar Oct 21 '22 10:10 poig

For example, quantum KNN requires either access to quantum memory to keep the states handy or re-creation of states every time when a distance is evaluated. Thus, the quantum version of the algorithm does not bring any advantages over the classical version. I can't say the above mentioned algorithms suffer from the same problem, they have to be studied and evaluated if they can bring value for this package. If you want to develop one of them, and possibly to contribute them, we can discuss in more details.

adekusar-drl avatar Oct 25 '22 08:10 adekusar-drl

Hi @poig @chin-jey, have there been recent developments on this discussion? Feel free to post a simple example here, as it might be useful for others. Once we've seen an implementation, we can evaluate together if it's worth turning it into a PR.

edoaltamura avatar Mar 08 '24 17:03 edoaltamura