qiskit-ignis icon indicating copy to clipboard operation
qiskit-ignis copied to clipboard

All fitters should accept IQ Data

Open dcmckayibm opened this issue 5 years ago • 2 comments

What is the expected behavior?

dcmckayibm avatar Nov 07 '19 06:11 dcmckayibm

I'm not sure this is wise to double up on types of data, single responsibility principle. We should have a most Base fitter that is agnostic of data type, and we could have one that chooses what type of fitter to instantiate, but at the end of the day, there should be a fitter that handles a specific sort of data. Its important to avoid things that work like magic (ie. passing any type of data to a fitter and having it automatically do its discrimination behind the scenes), these sorts of APIs end up not being very extensible and so if you want to do anything out of the ordinary it becomes hard to put the building blocks together.

taalexander avatar Nov 08 '19 14:11 taalexander

I'll probably soften my stance after thinking about it and I shouldn't have said all fitters. The examples I were thinking of are things like T1, T2, T2* where the IQ values don't need to be discriminated at all.

dcmckayibm avatar Nov 08 '19 18:11 dcmckayibm