prototype-qrao icon indicating copy to clipboard operation
prototype-qrao copied to clipboard

Published 20 hours ago • verified publisher icon qiskit-community

Adaptive QRAC

Open garrison opened this issue 2 years ago • 2 comments

Summary

Fixes #11. This may require some additional cleanup/comments in the code. And it should not be merged until the following issue is closed:

  • #7

Also, as part of this we should add a test case that will only pass once #7 is fixed. It is a bit concerning that all tests pass currently, even though we know there'd be an obvious problem if we were to merge this immediately.

Details and comments

garrison avatar May 06 '22 21:05 garrison

It is a bit concerning that all tests pass currently, even though we know there'd be an obvious problem if we were to merge this immediately.

I added a high-level statistical test of magic rounding in 0ed738274ce4cf1b95ba72ec7569bc0643b4a215, and this test fails on this branch, as expected. :+1:

garrison avatar Jun 18 '22 00:06 garrison

The main thing left to do here is to remove the following assumption, which is used throughout the magic rounding code:

https://github.com/qiskit-community/prototype-qrao/blob/bb6bd61a03ea6c2ef2ed80e3f6f9207170e33b3d/qrao/rounding_common.py#L61

garrison avatar Dec 09 '22 21:12 garrison