feat: support windows , run in multiple networks and support heartbeat
Hi, there. I made some features, hope can help you.
- Support compile projects on windows by goc.
- Fix goc client can not get the correct client-ip when the client has multiple networks, such as run in docker.
- The goc-client support register self to goc-server every 10 second. And the goc-sever kick out clients which is timeout (no register over 20 seconds) every 5 second.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: timandy
To complete the pull request process, please assign lyyyuna
You can assign the PR to them by writing /assign @lyyyuna in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/assign @lyyyuna
test case failed caused by server write log not flushed to disk. The ci in my fork repo is successed.
Hi @timandy, Thanks for your contributions. This seems a little big changes and we need more verifications especially for the new adapters on windows & k8s env.
Also, i am thinking whether it is necessary or not for the heartbeats enhancement, since now goc profile will ignore the failed registered services by default. Would you please provide more explanations for your thoughts about this feature?
Also, i am thinking whether it is necessary or not for the heartbeats enhancement, since now
goc profilewill ignore the failed registered services by default. Would you please provide more explanations for your thoughts about this feature?
@CarlJi Thanks for your review. Our service is deployed in the container. After several restarts, a lot of invalid clients will be generated. Although the goc server can filter invalid clients, these operations need network probing, which affects performance.
Codecov Report
Merging #321 (a9611f4) into master (5868a3e) will decrease coverage by
3.06%. The diff coverage is32.65%.
:exclamation: Current head a9611f4 differs from pull request most recent head 779b556. Consider uploading reports for the commit 779b556 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #321 +/- ##
==========================================
- Coverage 70.76% 67.69% -3.07%
==========================================
Files 34 35 +1
Lines 2035 2130 +95
==========================================
+ Hits 1440 1442 +2
- Misses 482 577 +95
+ Partials 113 111 -2
| Flag | Coverage Δ | |
|---|---|---|
| e2e-1.16.x | ? |
|
| e2e-1.17.x | ? |
|
| e2e-1.18.x | ? |
|
| e2e-1.19.x | ? |
|
| unittest-1.16.x | 67.69% <32.65%> (-2.97%) |
:arrow_down: |
| unittest-1.17.x | 67.60% <32.65%> (-3.06%) |
:arrow_down: |
| unittest-1.18.x | 67.60% <32.65%> (-3.06%) |
:arrow_down: |
| unittest-1.19.x | 67.69% <32.65%> (-3.07%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/build/run.go | 0.00% <0.00%> (ø) |
|
| pkg/cover/instrument.go | 20.83% <ø> (ø) |
|
| pkg/qiniu/tools.go | 0.00% <0.00%> (ø) |
|
| pkg/cover/server.go | 67.64% <5.55%> (-15.39%) |
:arrow_down: |
| pkg/cover/store.go | 69.44% <52.00%> (-14.59%) |
:arrow_down: |
| pkg/build/build.go | 80.95% <100.00%> (ø) |
|
| pkg/build/install.go | 64.10% <100.00%> (ø) |
|
| pkg/cover/cover.go | 72.04% <100.00%> (ø) |
|
| pkg/prow/job.go | 78.84% <100.00%> (ø) |
/unassign @lyyyuna /assign @CarlJi
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: timandy Once this PR has been reviewed and has the lgtm label, please ask for approval from carlji. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment