react-modal-dialog icon indicating copy to clipboard operation
react-modal-dialog copied to clipboard

Published 20 hours ago • verified publisher icon qimingweng

Heavy dependencies

Open karthikiyengar opened this issue 8 years ago • 3 comments

Is there any possibility of eliminating immutable and the entire lodash package from the dependencies? ~100kb seems to be a very high price to pay for a modal window.

karthikiyengar avatar Jan 26 '17 20:01 karthikiyengar

I tried different ways of building the project, based on the config of react-router, trying to remove the dependencies through the build process, and while I think the process could get better, I found that the main culprit of the large dependencies is active-event-stack.

I'll try to take a look at that project sometime soon.

In the meantime, here's the fork I've been working on to try and clean stuff up, if @qimingweng wants to take a look at it. If the changes are worth merging I can clean it up and rebase it.

edrpls avatar Feb 11 '17 05:02 edrpls

Any updates?

mqklin avatar Apr 03 '17 12:04 mqklin

@edrpls maybe you should try to submit your fork as a PR? It sounds like it has a lot of improvements! I'm also interested in cutting out the active-event-stack dependency

stevewillard avatar May 09 '17 17:05 stevewillard