react-modal-dialog icon indicating copy to clipboard operation
react-modal-dialog copied to clipboard

Published 20 hours ago • verified publisher icon qimingweng

sending event for onClose

Open narendrashetty opened this issue 7 years ago • 5 comments

sending event object when onClose is triggered will be very helpful when a small computation is needed.

narendrashetty avatar Sep 27 '16 11:09 narendrashetty

Can you specify what you mean in a PR/example of usage?

qimingweng avatar Sep 27 '16 14:09 qimingweng

I was talking about something like this https://github.com/narendrashetty/react-modal-dialog/commit/70b4b07590393b06ec5ac1d13e9cef9440601b1f because sometimes I have certain condition based on which certain operation needs to be performed. If i get an event object which gives me information on what triggered the close it'll be helpful

narendrashetty avatar Sep 27 '16 14:09 narendrashetty

@qimingweng Any update on the issue?

narendrashetty avatar Oct 18 '16 09:10 narendrashetty

I can send a PR for the same

narendrashetty avatar Oct 18 '16 09:10 narendrashetty

Hey, sorry for the long delay

Can you tell me what kind of computation you are doing with the event object? I mean I think it's a trivial change but still curious.

qimingweng avatar Nov 14 '16 19:11 qimingweng