Qi Luo

Results 63 comments of Qi Luo

Could you resolve conflict again?

@kannankvs As you can see "This branch has conflicts that must be resolved", could you check again?

@kannankvs you can continue resolve conflict and update this PR, no need to raise another PR (I checked the new one, still not in a good shape).

> clicommon.run_command(cmd + options, display_cmd=verbose) Use string array instead of string for `run_command`. --- In reply to: [1320111390](https://github.com/sonic-net/sonic-utilities/pull/2402#issuecomment-1320111390) [](http://example.com/codeflow?ancestors=1320111390) --- Refers to: show/platform.py:116 in 620e25b. [](commit_id = 620e25bc27211a50fc456d908860799c68b72ed0, deletion_comment =...

> clicommon.run_command(cmd + options, display_cmd=verbose) The comment is still applicable. --- In reply to: [1320111390](https://github.com/sonic-net/sonic-utilities/pull/2402#issuecomment-1320111390) [](http://example.com/codeflow?ancestors=1320111390,1320111390) --- Refers to: show/platform.py:116 in 620e25b. [](commit_id = 620e25bc27211a50fc456d908860799c68b72ed0, deletion_comment = False)

@judyjoseph What is the expectation? Check @ghooo two options above.

> class ChangeApplier: ChangeApplier could add a member `self.config_db` for the ConfigDBConnector. and rename existing `self.config_db` to `self.running_config` #Closed --- Refers to: generic_config_updater/change_applier.py:73 in 60bbcfe. [](commit_id = 60bbcfe5d1a393cc42a183d7930721d6a9018bf8, deletion_comment =...

@madhupalu Do you have more comments?

Please add positive and negative testcases.