Qi Luo comments

Results 63 comments of


                                            Qi Luo

Update dhcp relay test for option82 stripping

I guess you have a similar PR on master branch, could you mention it in PR description? and explain why not cherry-pick?

[submodule] Advance sonic-py-swsssdk pointer

@liuh-80 Could you help check the build failure? Related to swsssdk deprecation.

[sonic-config-engine] Replace os.system, replace yaml.load, remove subprocess with shell=True

This PR looks good to me. Could you dig deeper why the reverted PR was not caught by testcases on Github repo? Do we have test gap?

[sairedis] Replace memset functions

@kcudnik Could you review again?

[masic] 'show interfaces counters' reminds to use '-d all' option to check for internal links

This commit could not be cleanly cherry-picked to 202012. Please submit another PR.

[sfp] Fix issue: Application Advertisement is not well formatted

LGTM check is stuck. Will override.

Switch Port Modes and VLAN CLI Enhancement

@gechiang Do you have more concern?

Add Virtual Database Client + Unit Tests

Could you share the command line to unit test? We plan to add it into PR checker and automate it, even for this PR. #Closed

[config]: Add file check before load_minigraph command

> run_command("config qos reload", display_cmd=True) Since 'qos' is a local function, why we don't directly call it? --- Refers to: config/main.py:344 in ef57bac. [](commit_id = ef57bac77bcdbf0e04b0d2b0295484ee524b2331, deletion_comment = False)

Updated the CLIs for 202205 release

Please resolve conflict.