Qi Luo

Results 63 comments of Qi Luo

@dzhangalibaba Please also help review

@jipanyang @zhenggen-xu As we offline discussed I submit this PR. Please help review. Thanks for your solution and inspiration. #Closed

@ishidawataru Could you give a use case? The new feature should be backward-compatible by design.

@ishidawataru Yes, we are considering this. I am asking for a true use case so we could improve the implementation for backward compatibility. Do you have some sample code?

Offline discussed with @ishidawataru, this issue is a feature requirement. Use case: 1. If database_config.json is provided, use it 2. If no database_config.json at all, fallback to single Redis instance....

@ishidawataru The environment support is not available. But if you want to runtime change path, you could call `SonicDBConfig::initialize(PATH)` at the very beginning of your application. You mean TCP/unixsocket by...

Offline discussed with @dzhangalibaba @ishidawataru 1. add environment variable to swss-common/swsssdk-py/telemetry to specify database_config.json path 2. add new field in database_config.json to override TCP/unix_socket choice which previously specified in code....

What is the motivation? For your case, how about fixing syslog configurations?

I feel it is annoying for normal user just using default rsyslogd. I am ok if you change it only on a system with sksklogd, but don't change behavior for...

Could you explain the problem and the high level design in this PR? That may help us understand your code.