qiling icon indicating copy to clipboard operation
qiling copied to clipboard

io.UnsupportedOperation: fileno

Open 66hh opened this issue 4 years ago • 2 comments

使用IDLE时fileno函数会引发异常导致整个模块无法使用

Checklist

Which kind of PR do you create?

  • [x] This PR only contains minor fixes.
  • [ ] This PR contains major feature update.
  • [ ] This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • [ ] The new code conforms to Qiling Framework naming convention.
  • [ ] The imports are arranged properly.
  • [x] Essential comments are added.
  • [ ] The reference of the new code is pointed out.

Extra tests?

  • [ ] No extra tests are needed for this PR.
  • [ ] I have added enough tests for this PR.
  • [x] Tests will be added after some discussion and review.

Changelog?

  • [ ] This PR doesn't need to update Changelog.
  • [x] Changelog will be updated after some proper review.
  • [ ] Changelog has been updated in my PR.

Target branch?

  • [ ] The target branch is dev branch.

One last thing


66hh avatar Oct 30 '21 15:10 66hh

I am not sure we support running Qiling from an interactive Python interpreter.. I'll leave it to the others comment. Mean while, I would prefer a code change to be a little bit explanatory about what was the change and why (putting a vague exception name int he comments without a proper context doesn't help much...).

What about surrounding the problematic code with the appropriate try / catch and add comments it's for woroking around IDLE exceptions..?

elicn avatar Oct 31 '21 09:10 elicn

First,

base is still master. always pr to dev

i never use IDLE, not too sure will it even break the stdio. i guess @kabeor or @wtdcode know more.

xwings avatar Oct 31 '21 14:10 xwings