qiling icon indicating copy to clipboard operation
qiling copied to clipboard

Add x86_64 debug support

Open HackingFrogWithSunglasses opened this issue 2 years ago • 3 comments

As per https://github.com/qilingframework/qiling/pull/1217 - here is the x86_64 Qdb support

Checklist

Which kind of PR do you create?

  • [ ] This PR only contains minor fixes.
  • [ ] This PR contains major feature update.
  • [*] This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • [*] The new code conforms to Qiling Framework naming convention.
  • [*] The imports are arranged properly.
  • [*] Essential comments are added.
  • [ ] The reference of the new code is pointed out.

Extra tests?

  • [ ] No extra tests are needed for this PR.
  • [ ] I have added enough tests for this PR.
  • [*] Tests will be added after some discussion and review.

Changelog?

  • [ ] This PR doesn't need to update Changelog.
  • [ ] Changelog will be updated after some proper review.
  • [*] Changelog has been updated in my PR.

Target branch?

  • [*] The target branch is dev branch.

One last thing


@ucgJhe - you are welcome to comment.

elicn avatar Aug 31 '22 20:08 elicn

@HackingFrogWithSunglasses Thanks for your contribution, add some tests for Qdb will make this PR even better.

ucgJhe avatar Sep 07 '22 15:09 ucgJhe

Hey,

Thanks for your positive feedback, I really appreciate it.

Unfortunately, I simply don't have the time to refine this PR to the way in which you may like. I am also not the best placed person to do this, as I am not a developer. I simply decided to upstream these changes because I felt like other might want them.

You are absolutely welcome to adapt the PR and use it, or not. I am fine with either way :)

Hey, welcome to Qiling.

I will merge as per advice from @ucgJhe, thank you!

xwings avatar Sep 23 '22 06:09 xwings