qiita icon indicating copy to clipboard operation
qiita copied to clipboard

Add performance tests

Open antgonza opened this issue 10 years ago • 7 comments

We could add siege (http://www.joedog.org/index/siege-home) or something similar to test performance in travis. Perhaps set a minimal number of transactions for each of the most demanding blocks so we make sure that changes do not make them slower.

antgonza avatar Oct 27 '14 14:10 antgonza

That's just oriented on handling requests though but is a great start

On Mon, Oct 27, 2014 at 8:31 AM, Antonio Gonzalez [email protected] wrote:

We could add siege (http://www.joedog.org/index/siege-home) or something similar to test performance in travis. Perhaps set a minimal number of transactions for each of the most demanding blocks so we make sure that changes do not make them slower.

— Reply to this email directly or view it on GitHub https://github.com/biocore/qiita/issues/514.

wasade avatar Oct 27 '14 16:10 wasade

Air speed velocity could help us keep track of this: http://spacetelescope.github.io/asv/using.html

On (Oct-27-14| 9:13), Daniel McDonald wrote:

That's just oriented on handling requests though but is a great start

On Mon, Oct 27, 2014 at 8:31 AM, Antonio Gonzalez [email protected] wrote:

We could add siege (http://www.joedog.org/index/siege-home) or something similar to test performance in travis. Perhaps set a minimal number of transactions for each of the most demanding blocks so we make sure that changes do not make them slower.

— Reply to this email directly or view it on GitHub https://github.com/biocore/qiita/issues/514.


Reply to this email directly or view it on GitHub: https://github.com/biocore/qiita/issues/514#issuecomment-60619946

ElDeveloper avatar Oct 27 '14 16:10 ElDeveloper

:+1: simply for the name

On Mon, Oct 27, 2014 at 10:27 AM, Yoshiki Vázquez Baeza < [email protected]> wrote:

Air speed velocity could help us keep track of this: http://spacetelescope.github.io/asv/using.html

On (Oct-27-14| 9:13), Daniel McDonald wrote:

That's just oriented on handling requests though but is a great start

On Mon, Oct 27, 2014 at 8:31 AM, Antonio Gonzalez < [email protected]> wrote:

We could add siege (http://www.joedog.org/index/siege-home) or something similar to test performance in travis. Perhaps set a minimal number of transactions for each of the most demanding blocks so we make sure that changes do not make them slower.

— Reply to this email directly or view it on GitHub https://github.com/biocore/qiita/issues/514.


Reply to this email directly or view it on GitHub: https://github.com/biocore/qiita/issues/514#issuecomment-60619946

— Reply to this email directly or view it on GitHub https://github.com/biocore/qiita/issues/514#issuecomment-60622474.

wasade avatar Oct 27 '14 16:10 wasade

Hahaha, the people @ astropy presented this @ scipy, it was very cool.

On (Oct-27-14| 9:28), Daniel McDonald wrote:

:+1: simply for the name

On Mon, Oct 27, 2014 at 10:27 AM, Yoshiki Vázquez Baeza < [email protected]> wrote:

Air speed velocity could help us keep track of this: http://spacetelescope.github.io/asv/using.html

On (Oct-27-14| 9:13), Daniel McDonald wrote:

That's just oriented on handling requests though but is a great start

On Mon, Oct 27, 2014 at 8:31 AM, Antonio Gonzalez < [email protected]> wrote:

We could add siege (http://www.joedog.org/index/siege-home) or something similar to test performance in travis. Perhaps set a minimal number of transactions for each of the most demanding blocks so we make sure that changes do not make them slower.

— Reply to this email directly or view it on GitHub https://github.com/biocore/qiita/issues/514.


Reply to this email directly or view it on GitHub: https://github.com/biocore/qiita/issues/514#issuecomment-60619946

— Reply to this email directly or view it on GitHub https://github.com/biocore/qiita/issues/514#issuecomment-60622474.


Reply to this email directly or view it on GitHub: https://github.com/biocore/qiita/issues/514#issuecomment-60622573

ElDeveloper avatar Oct 27 '14 16:10 ElDeveloper

It was very cool! one thing to note, though, is that it depends on running on the same hardware. Therefore, I don't think there are hooks we can add to our CI, right?

On Mon, Oct 27, 2014 at 10:29 AM, Yoshiki Vázquez Baeza < [email protected]> wrote:

Hahaha, the people @ astropy presented this @ scipy, it was very cool.

On (Oct-27-14| 9:28), Daniel McDonald wrote:

:+1: simply for the name

On Mon, Oct 27, 2014 at 10:27 AM, Yoshiki Vázquez Baeza < [email protected]> wrote:

Air speed velocity could help us keep track of this: http://spacetelescope.github.io/asv/using.html

On (Oct-27-14| 9:13), Daniel McDonald wrote:

That's just oriented on handling requests though but is a great start

On Mon, Oct 27, 2014 at 8:31 AM, Antonio Gonzalez < [email protected]> wrote:

We could add siege (http://www.joedog.org/index/siege-home) or something similar to test performance in travis. Perhaps set a minimal number of transactions for each of the most demanding blocks so we make sure that changes do not make them slower.

— Reply to this email directly or view it on GitHub https://github.com/biocore/qiita/issues/514.


Reply to this email directly or view it on GitHub: https://github.com/biocore/qiita/issues/514#issuecomment-60619946

— Reply to this email directly or view it on GitHub https://github.com/biocore/qiita/issues/514#issuecomment-60622474.


Reply to this email directly or view it on GitHub: https://github.com/biocore/qiita/issues/514#issuecomment-60622573

— Reply to this email directly or view it on GitHub https://github.com/biocore/qiita/issues/514#issuecomment-60622757.

adamrp avatar Oct 27 '14 16:10 adamrp

Yeah, that was the biggest limitation to integrate this into most common CI systems, though I don't think it is prohibitive.

On (Oct-27-14| 9:33), adamrp wrote:

It was very cool! one thing to note, though, is that it depends on running on the same hardware. Therefore, I don't think there are hooks we can add to our CI, right?

On Mon, Oct 27, 2014 at 10:29 AM, Yoshiki Vázquez Baeza < [email protected]> wrote:

Hahaha, the people @ astropy presented this @ scipy, it was very cool.

On (Oct-27-14| 9:28), Daniel McDonald wrote:

:+1: simply for the name

On Mon, Oct 27, 2014 at 10:27 AM, Yoshiki Vázquez Baeza < [email protected]> wrote:

Air speed velocity could help us keep track of this: http://spacetelescope.github.io/asv/using.html

On (Oct-27-14| 9:13), Daniel McDonald wrote:

That's just oriented on handling requests though but is a great start

On Mon, Oct 27, 2014 at 8:31 AM, Antonio Gonzalez < [email protected]> wrote:

We could add siege (http://www.joedog.org/index/siege-home) or something similar to test performance in travis. Perhaps set a minimal number of transactions for each of the most demanding blocks so we make sure that changes do not make them slower.

— Reply to this email directly or view it on GitHub https://github.com/biocore/qiita/issues/514.


Reply to this email directly or view it on GitHub: https://github.com/biocore/qiita/issues/514#issuecomment-60619946

— Reply to this email directly or view it on GitHub https://github.com/biocore/qiita/issues/514#issuecomment-60622474.


Reply to this email directly or view it on GitHub: https://github.com/biocore/qiita/issues/514#issuecomment-60622573

— Reply to this email directly or view it on GitHub https://github.com/biocore/qiita/issues/514#issuecomment-60622757.


Reply to this email directly or view it on GitHub: https://github.com/biocore/qiita/issues/514#issuecomment-60623562

ElDeveloper avatar Oct 27 '14 16:10 ElDeveloper

I realize this is an old issue, but in the response from tornado tests is request_time which we can leverage to make sure it does not get above a certain time to process and return a page. Would make it easy to test performance for UI at least.

squirrelo avatar Apr 08 '16 23:04 squirrelo