qiita icon indicating copy to clipboard operation
qiita copied to clipboard

Published 20 hours ago • verified publisher icon qiita-spots

add sample validation page for wetlab

Open sarayupai opened this issue 3 years ago • 3 comments
trafficstars

sarayupai avatar Sep 20 '22 10:09 sarayupai

Coverage Status

Coverage increased (+0.02%) to 92.932% when pulling db1d266b1b3308ea119dac18ee5080d7865d77be on sarayupai:sample-validation into 17f25eda808a5a00da21ee649b6d50bc7b1e5081 on qiita-spots:dev.

coveralls avatar Sep 20 '22 12:09 coveralls

Thank you @sarayu. I asked @charles-cowart for a review but could you add tests to your new code?

antgonza avatar Sep 20 '22 12:09 antgonza

@sarayu @antgonza Waiting on unittests. Happy to review without them if you want the feedback.

charles-cowart avatar Sep 27 '22 17:09 charles-cowart

@charles-cowart, is this ready to be merged?

antgonza avatar Nov 02 '22 19:11 antgonza

Thank you @sarayupai and @charles-cowart !

antgonza avatar Nov 04 '22 12:11 antgonza