qiita icon indicating copy to clipboard operation
qiita copied to clipboard

Allow user to delete error messages from GUI.

Open fedarko opened this issue 4 years ago • 6 comments

Steps to reproduce:

  1. While logged in to Qiita, open https://qiita.ucsd.edu/study/description/10283
  2. In the Data Types section, click on "Metagenomic", then click on the "ID 4953" public prep
  3. The prep loads as expected, but I also see the following error message at the top of the page:
Screen Shot 2019-09-25 at 1 05 20 PM

This doesn't seem to be a major problem, but it is kind of disconcerting.

fedarko avatar Sep 25 '19 20:09 fedarko

This means someone tried to delete an artefact on the page and received the warning - not necessarily you because the message will NEVER go away.

On Wed, Sep 25, 2019 at 1:07 PM Marcus Fedarko [email protected] wrote:

Steps to reproduce:

  1. While logged in to Qiita, open https://qiita.ucsd.edu/study/description/10283
  2. In the Data Types section, click on "Metagenomic", then click on the "ID 4953" public prep
  3. The prep loads as expected, but I also see the following error message at the top of the page:

[image: Screen Shot 2019-09-25 at 1 05 20 PM] https://user-images.githubusercontent.com/4177727/65635442-2b3c3d00-df95-11e9-8785-bb885950a7b1.png

This doesn't seem to be a major problem, but it is kind of disconcerting.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/biocore/qiita/issues/2950?email_source=notifications&email_token=AAPL3AGVKJXPVKHE5FCKMF3QLPAHDA5CNFSM4I2RPRQ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HNWOFZQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPL3AFG3DFPMHH2UGOJ3QLQLPAHDANCNFSM4I2RPRQQ .

-- Gail Ackermann Knight Lab UCSD [email protected] [email protected]

ackermag avatar Sep 25 '19 20:09 ackermag

Huh, I didn't know that! It's good to know I'm not messing something up at least :)

The behavior of the error message never going away seems strange to me. I imagine it will confuse other people, also. It might be worth only showing it once, if that's possible (but if not I understand).

fedarko avatar Sep 25 '19 21:09 fedarko

"Traditionally" we have left those messages on the screen and don't allow the user to delete them until another action is performed; the message is erased after another job is successful. As of today, I think it will be good to allow the user to delete them. @ackermag, do you agree?

antgonza avatar Sep 30 '19 08:09 antgonza

Yes I agree. It is very confusing to the average user.

On Mon, Sep 30, 2019 at 1:18 AM Antonio Gonzalez [email protected] wrote:

"Traditionally" we have left those messages on the screen and don't allow the user to delete them until another action is performed; the message is erased after another job is successful. As of today, I think it will be good to allow the user to delete them. @ackermag https://github.com/ackermag, do you agree?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/biocore/qiita/issues/2950?email_source=notifications&email_token=AAPL3AH45OPKTQ63RGPHUF3QMGY6PA5CNFSM4I2RPRQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD742RLY#issuecomment-536455343, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPL3ADZ6WNYQQH626TFUPLQMGY6PANCNFSM4I2RPRQQ .

-- Gail Ackermann Knight Lab UCSD [email protected] [email protected]

ackermag avatar Sep 30 '19 14:09 ackermag

Thank you both, changing issue title to reflect this.

antgonza avatar Oct 01 '19 13:10 antgonza

Just a quick message about this issue. The main complexity to fix this issue is that we currently are not passing the redis-key to the bootstrapAlert JS method that displays the error in the webpage. Thus, we are going to need to update/fix the 60+ bootstrapAlert calls to pass this value so we can pass that redis-key information for delete.

antgonza avatar Jan 02 '20 17:01 antgonza