qiita icon indicating copy to clipboard operation
qiita copied to clipboard

Incorrect formatting of data for PATCH requests

Open ElDeveloper opened this issue 7 years ago • 4 comments
trafficstars

Several of the PATCH requests in Qiita are sending data via the request's arguments, whereas the standard expects that the data be sent via the body of the request as JSON.

ElDeveloper avatar Aug 28 '18 22:08 ElDeveloper

Thanks. Just to better classify this issue, what are the implications of this?

antgonza avatar Aug 28 '18 23:08 antgonza

One possible implication (which I found in #2649) was that the data could possibly be mangled.

On (Aug-28-18|16:47), Antonio Gonzalez wrote:

Thanks. Just to better classify this issue, what are the implications of this?

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/biocore/qiita/issues/2648#issuecomment-416776453

ElDeveloper avatar Aug 29 '18 00:08 ElDeveloper

Mangle how? Like it will not work?

antgonza avatar Aug 29 '18 02:08 antgonza

Perhaps mangle was an overstatement. Yes, one of my values was being parsed as a list even though the client was transmitting a single string. The data was not wrong but it should have not been transformed into a list.

ElDeveloper avatar Aug 29 '18 16:08 ElDeveloper