qibocal icon indicating copy to clipboard operation
qibocal copied to clipboard

Mermin experiment

Open andrea-pasquale opened this issue 10 months ago • 3 comments

This PR adds a protocol for computing mermin inequality for 3 qubits (single value without sweep).

Checklist:

  • [ ] Reviewers confirm new code works as expected.
  • [ ] Tests are passing.
  • [ ] Coverage does not decrease.
  • [ ] Documentation is updated.
  • [ ] Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • [ ] Qibo: master
    • [ ] Qibolab: main
    • [ ] Qibolab_platforms_qrc: main

andrea-pasquale avatar Mar 25 '24 10:03 andrea-pasquale

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.50%. Comparing base (c4fdce8) to head (b05f7c5).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #770      +/-   ##
==========================================
- Coverage   97.50%   97.50%   -0.01%     
==========================================
  Files         123      128       +5     
  Lines        9701     9851     +150     
==========================================
+ Hits         9459     9605     +146     
- Misses        242      246       +4     
Flag Coverage Δ
unittests 97.50% <100.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/qibocal/protocols/__init__.py 100.00% <ø> (ø)
...ibocal/protocols/two_qubit_interaction/__init__.py 100.00% <100.00%> (ø)
...protocols/two_qubit_interaction/mermin/__init__.py 100.00% <100.00%> (ø)
...protocols/two_qubit_interaction/mermin/circuits.py 100.00% <100.00%> (ø)
...protocols/two_qubit_interaction/mermin/protocol.py 100.00% <100.00%> (ø)
...l/protocols/two_qubit_interaction/mermin/pulses.py 100.00% <100.00%> (ø)
...al/protocols/two_qubit_interaction/mermin/utils.py 100.00% <100.00%> (ø)
...rc/qibocal/protocols/two_qubit_state_tomography.py 99.31% <100.00%> (+0.02%) :arrow_up:

... and 2 files with indirect coverage changes

codecov[bot] avatar Mar 25 '24 10:03 codecov[bot]

@andrea-pasquale Could we pick back up? I can help in anything needed to move this from draft to pull request.

igres26 avatar May 17 '24 14:05 igres26

@andrea-pasquale Could we pick back up? I can help in anything needed to move this from draft to pull request.

It would be nice if you could provide a version of the experiment where we perform a sweep to show a plot similar to CHSH. Otherwise we can merge (without the sweep). I'm also working on other stuff so if you have time and you would like to finalize it that would be appreciated :)

andrea-pasquale avatar May 20 '24 07:05 andrea-pasquale