Amex-Offers-Helper icon indicating copy to clipboard operation
Amex-Offers-Helper copied to clipboard

Script is adding every other offer, not each one

Open a1ch3mist opened this issue 4 years ago • 6 comments

Using Chrome devtools

The script is adding every other offer, not each one. Also seems to occasionally skip more than every other one.

a1ch3mist avatar Sep 09 '20 21:09 a1ch3mist

@a1ch3mist thanks for reporting! Will take a look at the issue

qibinlou avatar Sep 10 '20 13:09 qibinlou

@a1ch3mist could you help try out latest version https://github.com/qibinlou/Amex-Offers-Helper/blob/master/index.js ?

Also FYI, there are two categories of offer buttons on the offer list page 1) no-action-required offers 2) action-required offers such as redirecting to trycaviar.com to create an account. This script only help users register no-action-required offers.

qibinlou avatar Sep 17 '20 13:09 qibinlou

It's still missing some. Perhaps you have to delay between each click? AMEX Offers takes a second or two to "register" the click. Tried on an account with 96 offers available.

A 2nd run caught the rest of them.

I did catch a "Sorry About That!" error quickly on the Web page while I was watching it add, so maybe there are occasional server errors?

Is there a 100-limit on the actual added offers as well, or just on the available?

a1ch3mist avatar Sep 17 '20 17:09 a1ch3mist

@a1ch3mist the script waits 2s after each click on Add To Card button so there shouldn't be a rate limiting by Amex (at least when I tested it on my account for multiple times). I believe Amex caps the available offers to at most 100 per card in my experience.

Regarding It's still missing some., to clarify, do those missed ones have Add To Card text or other labels? The script will only automate the clicks on buttons with Add To Card label because those buttons map to no-action-required offers.

qibinlou avatar Sep 20 '20 19:09 qibinlou

Correct, those were offers with the "Add to Card" button. I understand the difference like you said. 2s might not be enough time. I've seen some take longer than that.

a1ch3mist avatar Sep 20 '20 20:09 a1ch3mist