SINE icon indicating copy to clipboard operation
SINE copied to clipboard

代码与论文不一致 Code does not match the paper

Open UesugiErii opened this issue 3 years ago • 4 comments

  1. X_hat^u 加上X^u的残差为什么没在论文中提及?
  2. C^u_apt 缺少LayerNorm4以及后续多出来的运算?
  3. (7)的τ去哪了
  4. (3)里面为什么有τ
  5. (3)的W3去哪了
  6. (5)的LayerNorm3在哪
  7. 很多地方加上了position_embedding, 论文为什么不提及?

  1. why is the residual of X_hat^u plus X^u not mentioned in the paper?
  2. C^u_apt is missing LayerNorm4 and the subsequent extra operations?
  3. where is the τ of (7)?
  4. why is there τ in (3)?
  5. where did the W3 of (3) go?
  6. where is the LayerNorm3 of (5)?
  7. many places added position_embedding, why not mentioned in the paper?

UesugiErii avatar Sep 14 '21 07:09 UesugiErii

And in tf.nn.sampled_softmax_loss, use num_sampled=self.neg_num * self.batch_size is incorrect, you can refer to https://github.com/THUDM/ComiRec/issues/3

UesugiErii avatar Sep 14 '21 08:09 UesugiErii

In your paper, you write we treat all the items that the user has not interacted with as negative items But in your code, you treat the result of index.search(user_embs, topN) as negative items, but index.search(user_embs, topN) may contain items that the user has interacted with

UesugiErii avatar Feb 22 '22 05:02 UesugiErii

确实有很多和论文不一致的地方。

Fred199683 avatar Mar 07 '23 12:03 Fred199683

损失函数上,Lc在代码里被换成了另外一个,也跟论文对不上。

chungewoqu2 avatar Jul 26 '23 09:07 chungewoqu2