QGIS icon indicating copy to clipboard operation
QGIS copied to clipboard

Improve UX of layer style categories with html

Open signedav opened this issue 1 year ago • 8 comments

What means we provide displayRole in html format and have a delegate for the display text.

Description

There is a mess in the categories (see https://github.com/qgis/QGIS/issues/58432 and https://github.com/qgis/QGIS/issues/45146)

To reorder them would break backwards compatibility (what doesn't mean that we should not do it). But meanwhile this UX only improvement should help in the meantime.

image

  • The grey texts are more descriptive and always there (because tooltips are nice, but if you don't know about them you won't look for them)

  • There are new icons for layer configuration (without being mistaken with the source, fields (contains a small forms in there, to indicate it's a little bit more than just the fields) and notes (was missing before)

  • Model and Delegate are now available in the API

  • [x] Improve design (grey)

  • [x] word wrap

  • [x] Improve texts with info from https://github.com/qgis/QGIS/issues/45146#issuecomment-2345813144

  • [x] maybe better icons ( an notes icon)

  • [x] expose in the API (to ensure plugins using the same)

signedav avatar Sep 13 '24 13:09 signedav

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 816da02398f5bf5cd153e937307ccfee32f8815f)

github-actions[bot] avatar Sep 13 '24 13:09 github-actions[bot]

Nice! I think it could look a bit less busy if the longer, informative lines used a grey or thinner or smaller font.

kannes avatar Sep 13 '24 19:09 kannes

Nice! I think it could look a bit less busy if the longer, informative lines used a grey or thinner or smaller font.

Thanks. I tried italic and it seemed noisy. Maybe grey would be worth a try...

signedav avatar Sep 13 '24 20:09 signedav

@signedav , good move, that'll help guide people through this otherwise relatively obscure set of categories. +1 to maybe have the text grayed out and/or slightly smaller (relative to main font app size).

I've not compiled it so maybe it does already, but list should allow for the description text to wrap to new lines when the dialog is narrower than the screenshot above.

nirvn avatar Sep 14 '24 05:09 nirvn

Opinions on that @nirvn @kannes ?

grey small grey-and-small
Screenshot from 2024-09-14 23-08-37 Screenshot from 2024-09-14 23-09-49 Screenshot from 2024-09-14 23-05-02

I like the look of the smaller font, but I would rather "not read" it than the grey one. Anyway I'm -1 to have small and grey.

signedav avatar Sep 14 '24 21:09 signedav

+1 for grey

kannes avatar Sep 18 '24 20:09 kannes

Nice work, thanks! Just a small visual inconstancy in night mapping at the note icon: I would suggest coloring the paper white here, similar to the clock icon. Unfortunately, we can then no longer use the mIndicatorNotes icon, which is used as a monochrome icon in the layer overview.

fiddlersfan avatar Sep 26 '24 16:09 fiddlersfan

Considered that @fiddlersfan

signedav avatar Sep 26 '24 19:09 signedav

Can we merge that? All inputs have been considered.

signedav avatar Oct 07 '24 08:10 signedav