add part to geometryless feature does not work on single curvepolygon layer

[3nids]

What is the bug or the crash?

add part map does not work for single curvepolygon layers when trying to add part to geometryless feature

Steps to reproduce the issue

create a curvepolygon memory layer create a geometryless feature from the attribute table select it try to add part

Versions

at least 3.34+

Supported QGIS version

• [X] I'm running a supported QGIS version according to the roadmap.

New profile

• [ ] I tried with a new QGIS profile

Additional context

No response

[3nids]

it seems to be fixed in master by https://github.com/qgis/QGIS/commit/71f3cc70370d1d190984e4350f5d270dc1c36761

[ponceta]

@lbartoletti is it fixed in nightly?

Because testing it with latest nightly give me this behaviour :

• [X] Commit a polygon drawn in a curvepolygonz can be added as geometry part (scenario 4)
• [ ] Commit a curvepolygon drawn in a curvepolygonz keep the same error message as before (scenario 3)

(Scenarii are described in https://github.com/qgis/QGIS/pull/57261#issuecomment-2112882094)

[3nids]

@Djedouas this means we probably need to drop the flatType call?

[3nids]

and we need to extend the map tool test with this scenario

[Djedouas]

@Djedouas this means we probably need to drop the flatType call?

Not sure, I don't think that it's related to the Z part of the geometry. Looking into this.

[Djedouas]

Using the Windows build from the PR https://github.com/qgis/QGIS/pull/57636#issuecomment-2142713966 each scenario works.

The nightly build is on commit 5481dabd32 which is older than our fix.

[ponceta]

I can confirm it is fixed in QGIS 3.34.8 and Master (two different fixes)