QGIS icon indicating copy to clipboard operation
QGIS copied to clipboard

Published 20 hours ago • verified publisher icon qgis

Fix merge features with hidden fields

Open vaahtokarkki opened this issue 11 months ago • 3 comments

Description

Merge selected features tool won't merge correctly hidden attribute values. With this PR the tool will use for hidden fields the default value defined for field, or the value from the selected feature, if any is selected.

Fixes #28253 Backport needed for 3.34 and 3.36

vaahtokarkki avatar Mar 12 '24 17:03 vaahtokarkki

@nyalldawson could you review this as well?

Joonalai avatar Mar 20 '24 07:03 Joonalai

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request. If there is no further activity on this pull request, it will be closed in a week.

github-actions[bot] avatar Apr 04 '24 02:04 github-actions[bot]

Not stale, just waiting for review. Could perhaps some of you @nyalldawson, @3nids, @m-kuhn please review this?

Joonalai avatar Apr 04 '24 05:04 Joonalai

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request. If there is no further activity on this pull request, it will be closed in a week.

github-actions[bot] avatar May 07 '24 02:05 github-actions[bot]

Again not stale and just waiting for the GitHub actions to run. Could you @elpaso allow them to run, thanks again!

vaahtokarkki avatar May 07 '24 05:05 vaahtokarkki

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 57cc7ed3824dd68df12fdbfa81632706c40beeab)

github-actions[bot] avatar May 07 '24 08:05 github-actions[bot]

Again not stale and just waiting for the GitHub actions to run. Could you @elpaso allow them to run, thanks again!

Can you try to rebase from current master an force-push?

elpaso avatar May 07 '24 16:05 elpaso

@vaahtokarkki thank you for you contribution. I'm sorry the review process took so long, the automated CI sometimes seems to work against us.

elpaso avatar May 08 '24 07:05 elpaso

@elpaso there does not seem to be a backport PR of this fix for release-3_34? Should we make it manually or is "Backport queued_ltr_backports" ending up to some 3.34 release?

Joonalai avatar May 08 '24 08:05 Joonalai

@elpaso there does not seem to be a backport PR of this fix for release-3_34? Should we make it manually or is "Backport queued_ltr_backports" ending up to some 3.34 release?

queued_ltr_backports will be merged in 3.34 but not in the next point release, we skip one point release to give extra time for testing before merging into a LTR.

elpaso avatar May 08 '24 08:05 elpaso