QGIS icon indicating copy to clipboard operation
QGIS copied to clipboard

Fix performance issue when dropping many layers to a GeoPackage (fixes #29510)

Open rouault opened this issue 1 year ago • 8 comments

  • QgsTaskManager::resolveDependencies() and taskId(): fix bad performance when long chain of task dependencies
  • Add a QgsTaskWithSerialSubTasks class
  • QgsDatabaseItemGuiProvider() and QgsGeoPackageDataItemProvider(): use QgsTaskWithSerialSubTasks to fix performance issue when dropping many layers (fixes #29510)

rouault avatar Jan 23 '24 22:01 rouault

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 8af6648130ba61c185b3a1291b678fdb71f2d462)

github-actions[bot] avatar Jan 23 '24 23:01 github-actions[bot]

@nyalldawson when you have a chance, this should be ready to re-review

rouault avatar Feb 26 '24 22:02 rouault

Tests failed for Qt 5

One or more tests failed using the build from commit 8af6648130ba61c185b3a1291b678fdb71f2d462

WMS_GetMap_Highlight_Empty_Labels

WMS_GetMap_Highlight_Empty_Labels

Test failed at test_wms_getmap_highlight_empty_labels at tests/src/python/test_qgsserver_wms_getmap.py:1391

Rendered image did not match tests/testdata/control_images/qgis_server/WMS_GetMap_Highlight_Empty_Labels/WMS_GetMap_Highlight_Empty_Labels.png (found 271 pixels different)

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

github-actions[bot] avatar Mar 20 '24 03:03 github-actions[bot]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request. If there is no further activity on this pull request, it will be closed in a week.

github-actions[bot] avatar Apr 04 '24 02:04 github-actions[bot]

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

github-actions[bot] avatar Apr 11 '24 02:04 github-actions[bot]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request. If there is no further activity on this pull request, it will be closed in a week.

github-actions[bot] avatar Apr 30 '24 02:04 github-actions[bot]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request. If there is no further activity on this pull request, it will be closed in a week.

github-actions[bot] avatar May 15 '24 02:05 github-actions[bot]

keep alive...

rouault avatar May 15 '24 11:05 rouault