Piotr Kufel
Piotr Kufel
Note: it may be preferable to merge https://github.com/nushell/nushell/pull/14078 first (since it's basically a already reviewed code) so that the diff here is smaller.
Because IDs are a part of history, I wanted to leave an option to import them too. Because right now IDs are continuous and start from 0/1, that has the...
> I'm not sure I understand this. In a text-backed history, it's simply a flat-file with no indices. Deleting a history item changes the "index" of every item after it....
It should be ready, provided you want to retain the `--include-ids` flag. Or we can remove it in the name of minimizing UX surface for starters. Also > Also note...
It's not destructive by default: unless `--include-ids` is specified, we erase IDs from the input (perhaps we should fail on IDs being piped, not sure), which causes reedline to always...
> I don't understand this really because the description of the PR says, Sorry, poor phrasing. Updated to never allow overwriting IDs and updated the description.
Any idea how to deal with Clippy? What is suggests doesn't compile and the CI doesn't seem to honor warning annotations.
> This PR makes the history path available as a config.nu setting as $env.config.history.path. Ah, that's true. I realized I kept finding (and addressing) more and more uses of history...
Done (it's still mostly the same, just doesn't have the field)
Anything still missing?