vector-db-benchmark icon indicating copy to clipboard operation
vector-db-benchmark copied to clipboard

`max_optimization_threads: 0` doesn't disable indexing

Open ffuugoo opened this issue 1 year ago • 2 comments

While running vector-db-benchmarks I've noticed that

  • we are updating the collection with max_optimization_threads: 0 before uploading points
  • and then once again with max_optimization_threads: 1 after upload is finished
  • I assume this is done to disable optimization/indexing during points upload
  • but I've noticed that max_optimization_threads: 0 doesn't disable indexing
    • I've disabled the max_optimization_threads: 1 request and had a collection fully indexed with max_optimization_threads: 0

If max_optimization_threads was intended to disable/enable indexing, then vector-db-benchmark can be updated to use indexing_threshold: 0 instead.

Screenshot

Notice indexed_vectors_count near the top and max_optimization_threads at the bottom.

Screenshot 2023-10-18 at 16 13 13

ffuugoo avatar Oct 19 '23 10:10 ffuugoo

@generall Do we also want an issue in qdrant regarding max_optimization_threads: 0?

ffuugoo avatar Oct 19 '23 10:10 ffuugoo

You're right about this @ffuugoo.

Will fix this in the next benchmarks run.

KShivendu avatar Jan 24 '24 09:01 KShivendu