qdrant
qdrant copied to clipboard
Lookup: expose feature to REST and gRPC interfaces
Exposes the lookup feature in the Groups API, in both REST and gRPC interfaces
Dependencies
Builds on top of #1996
TO DOs:
- [x] Expose feature
- [x] Write integration tests
All Submissions:
- [x] Have you followed the guidelines in our Contributing document?
- [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
New Feature Submissions:
- [x] Does your submission pass tests?
- [x] Have you formatted your code locally using
cargo fmt
command prior to submission? - [x] Have you checked your code using
cargo clippy
command?
Changes to Core Features:
- [x] Have you written new tests for your core changes, as applicable?
- [x] Have you successfully ran tests with your changes locally?
Could you temporarily point this PR to lookup-in-group-by
instead while it is in draft, until https://github.com/qdrant/qdrant/pull/1996 is merged? That way the diff would only show new changes. Once the dependency is merged you can point to dev
again and rebase (or cherry-pick if needed). I want to prevent investing time in the same code multiple times.
Not sure how you feel about that. I've done it a few times. Though the rebase process is a bit tricky I think it helps with the stacked reviews. :smile:
Too bad you can't really comment on diffs :(
I hadn't thought of that, but it makes sense! The rebase process is something I am actively doing anyway 👍
Much better now, thanks for the suggestion @timvisee
@generall I agree that vectors are not needed for the default scenario. Do you approve keeping with_payload=true
and with_vector=false
as defaults? ~Might be a little exotic with respect of our default false on with_*
's but i~ It makes sense here
After some consideration, I decided to rollback changes with multiple lookups
in grpc. Sorry for taking it back and forward too much.
Functionality-wise I think it works alright!