qdrant-client icon indicating copy to clipboard operation
qdrant-client copied to clipboard

Fix float precision error

Open I8dNLo opened this issue 8 months ago • 2 comments

Check if vectors are too close Regenerate if they are Round as a constant

I8dNLo avatar Mar 17 '25 12:03 I8dNLo

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
Latest commit aa902871f740d2d8e9459bc78d91293dca1e1e01
Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/67f7d2ade28834000889865f
Deploy Preview https://deploy-preview-926--poetic-froyo-8baba7.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 17 '25 12:03 netlify[bot]

📝 Walkthrough

Walkthrough

The changes introduce several new functions in tests/fixtures/points.py, including find_min_dist, which calculates the minimum cosine distance between vectors, and check_distance, which checks if this distance exceeds a specified threshold. The generate_dense_vectors function generates dense vectors while ensuring a minimum distance check. Additionally, new functions for multivector generation, such as generate_random_multivector, have been added, along with functions for generating points using single or multiple dense vectors. The generate_sparse_or_multivector_points function has also been introduced to facilitate point generation in various formats. The random_vectors function has been updated to use a constant for rounding, enhancing consistency. In tests/congruence_tests/test_collections.py, the vector_size variable in the test_init_from function has been increased from 2 to 200, impacting the size of generated vectors while preserving the function's overall logic. The addition of the @pytest.mark.floatprecision decorator to several test functions across different test files enhances the handling of floating-point precision in the tests.

✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Mar 17 '25 12:03 coderabbitai[bot]