qdrant-client icon indicating copy to clipboard operation
qdrant-client copied to clipboard

Published 20 hours ago • verified publisher icon qdrant

Is grpcio-tools a necessary non-dev dependency?

Open tjni opened this issue 10 months ago • 6 comments

Hello!

I noticed that grpcio-tools is listed as both a dev and non-dev dependency. Is it needed in non-dev? (If not, I'd like to remove it from the dependency tree and can submit a PR.)

tjni avatar Jan 12 '25 06:01 tjni

~it is necessary~

we need to check

generall avatar Jan 12 '25 10:01 generall

Thank you for the consideration! On disk, the shared object that it brings in is quite large, hence why I noticed it.

tjni avatar Jan 13 '25 03:01 tjni

On disk, the shared object that it brings in is quite large, hence why I noticed it.

and for legacy systems with no grpcio-tools.whl nor C build toolchains, this dependency will break the installation of qdrant-client.

jizhilong avatar Jan 14 '25 07:01 jizhilong

Hi @generall, have you had any time to check?

tjni avatar Jan 24 '25 01:01 tjni

hey @tjni

grpcio-tools is not a required non-dev dependency, but protobuf is we'll try to replace grpcio-tools with just protobuf

joein avatar Jan 30 '25 20:01 joein

We've replaced it in dev and it will be available with qdrant-client v1.14

joein avatar Mar 17 '25 14:03 joein

Qdrant-client v1.14.1 has been released and does not require grpcio-tools

joein avatar Apr 23 '25 10:04 joein