qdrant-client icon indicating copy to clipboard operation
qdrant-client copied to clipboard

use grpc in query congruence tests

Open coszio opened this issue 1 year ago • 1 comments

Makes query congruence tests to use grpc too, but parametrized with a fixture for easier debugging

coszio avatar Jul 22 '24 19:07 coszio

I am not super sure about this update, it doubles the time we need for these tests

This is the time for query tests on universal-search-query-group-api branch (0:01:48)

On this branch: (0:03:44)

I tried adding grpc client into the existing tests like:

remote_client = init_remote(prefer_grpc=False)
grpc_remote_client = init_remote(prefer_grpc=True)

and then adding compare_client_collections calls like:

compare_client_results(local_client, remote_client, searcher.dense_query_fusion)
compare_client_results(local_client, remote_client, searcher.deep_dense_queries_fusion)

->

compare_client_results(local_client, remote_client, searcher.dense_query_fusion)
compare_client_results(local_client, remote_client, searcher.deep_dense_queries_fusion)

compare_client_results(local_client, grpc_remote_client, searcher.dense_query_fusion)
compare_client_results(local_client, grpc_remote_client, searcher.deep_dense_queries_fusion)

the time is around 1:50 (probably because the most heavy test have already been using prefer_grpc=False, True

joein avatar Jul 25 '24 15:07 joein

closing in favour of #726

joein avatar Aug 09 '24 15:08 joein