qdrant-client icon indicating copy to clipboard operation
qdrant-client copied to clipboard

Bug report: Publish pipeline

Open michaelfeil opened this issue 1 year ago • 4 comments

Benefit: If someone submits a PR, they cannot steal the PYPI_API_TOKEN. This could potentially be any current contributor. https://github.com/qdrant/fastembed/pull/304

Adapted from: https://github.com/pypa/gh-action-pypi-publish?tab=readme-ov-file#trusted-publishing

There are some steps that the admin of this repo need to do. Both are UI actions.

TODO:

  1. Pypi.org Follow pypi guide https://docs.pypi.org/trusted-publishers/adding-a-publisher/

This should roughly do it

- owner "qdrant"
- repository name "fastembed"
- workflow "publish.yml"
- environment name "publish" # The name of environment in the yaml needs to match the name of the github UI and what you put on pypi
  1. Github.com Create a environment named "publish" in github UI under environments. Below a screenshot of project github.com/michaelfeil/infinity and added e.g. me as Required Reviewer (e.g. if someone else pushes a tag to my repo, this stalls the github CI, and I get a notification to approve the publish.yml workflow) image

michaelfeil avatar Jul 20 '24 03:07 michaelfeil

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
Latest commit 9e7511bd9810b797facb037632e88904a5519d78
Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/669b335982c85c000825cb09
Deploy Preview https://deploy-preview-699--poetic-froyo-8baba7.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 20 '24 03:07 netlify[bot]

@joein Any thoughts on this?

michaelfeil avatar Jul 30 '24 05:07 michaelfeil

hi @michaelfeil

sorry for the late response, we'll review it in the closest time

thank you for the contribution :)

joein avatar Jul 30 '24 07:07 joein

@joein Sure, let me know!

michaelfeil avatar Aug 13 '24 00:08 michaelfeil