qdrant-client icon indicating copy to clipboard operation
qdrant-client copied to clipboard

Fix grpc port by configure via url

Open ainyava opened this issue 1 year ago • 3 comments

I've noticed that when configuring Qdrant endpoint via URL it does not set grpc_port so I've made a simple change.

ainyava avatar Jun 10 '24 14:06 ainyava

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
Latest commit 109a653890b12c89f76dabe31c7b7c2c2a051cac
Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/666756b094299500084e4839
Deploy Preview https://deploy-preview-645--poetic-froyo-8baba7.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 10 '24 14:06 netlify[bot]

Hi @ainyava

Thank you for the contribution!

However, I don't think we'll be able to merge it:

Using both grpc and rest simultaneously is a valid case (and we can't assign the same port for two interfaces) grpc interface does not implement some of the snapshots/shards/storage methods, and the rest one is used in that case

joein avatar Jun 10 '24 14:06 joein

Oh I didn't know about that, however I think its kind of misleading that we cant use URL and host/port params at the same time while its not clear that how to configure both protocols separately

The real problem we're facing is:

We have Qdrant on Kubernetes and have access to it using Ingress (through port 443) so we need to configure separate endpoints (because our Ingress controller adds some annotation for gRPC, we've defined two ingresses for HTTP/gRPC) so we need to configure port and hostnames for HTTP/gRPC separately.

For now

I just copied every HTTP configuration and prefixed with grpc and changed get_channel function so you could review it again but:

Final Solution

I would appreciate some suggestions on how to resolve this in a clear manner, also If its needed to change the source code, It would be a great pleasure for me to do so.

Thanks, Ainyava

ainyava avatar Jun 10 '24 19:06 ainyava