qdrant-client icon indicating copy to clipboard operation
qdrant-client copied to clipboard

Use `mypy-protobuf` for better grpc type stubs

Open coszio opened this issue 1 year ago • 2 comments

This adds mypy type stub generation for better DX with grpc types.

  • Adds mypy-protobuf to poetry dev dependencies
  • Adds --mypy_out flag to grpc client generator

dev: image

PR: image

All Submissions:

  • [x] Contributions should target the dev branch. Did you create your branch from dev?
  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

coszio avatar Feb 26 '24 15:02 coszio

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
Latest commit 6b91b404999cf2c738bb0ac0e4b23c0b51f63526
Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/66d00000db2e2a0008e46e57
Deploy Preview https://deploy-preview-506--poetic-froyo-8baba7.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 26 '24 15:02 netlify[bot]

Recreated the type stubs with the dev branch of qdrant core

coszio avatar Mar 04 '24 13:03 coszio

@joein anything against this? Otherwise I think it makes our life easier

coszio avatar Aug 28 '24 22:08 coszio

Let's merge it before 1.11.2, but not right now

joein avatar Aug 29 '24 05:08 joein

I added the mypy stubs in #758, now that this one is approved. To not repeat client generation, I will close this one in favor of the other one.

coszio avatar Aug 29 '24 22:08 coszio