qdrant-client icon indicating copy to clipboard operation
qdrant-client copied to clipboard

feat: Add URL information in UnexpectedResponse

Open SamirPS opened this issue 1 year ago • 4 comments

This commit add the url in the UnexpectedResponse class, and modify the for_response and str to display the URL.

Signed_Off_by: Samir Akarioh [email protected] resolve #456

All Submissions:

  • [x] Contributions should target the dev branch. Did you create your branch from dev?
  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. [ ] Does your submission pass tests?
  2. [x] Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?

Changes to Core Features:

  • [ ] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your core changes, as applicable?
  • [ ] Have you successfully ran tests with your changes locally?

SamirPS avatar Feb 03 '24 13:02 SamirPS

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
Latest commit 53baa5087b8415cb6deff2f6237e6b0c409058b2
Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/65be434493b4230008e86761
Deploy Preview https://deploy-preview-479--poetic-froyo-8baba7.netlify.app/qdrant_client.conversions.conversion
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 03 '24 13:02 netlify[bot]

Unfortunately, we can't just change files in http/ (or grpc/) because they are auto-generated.)

And the generator is not public

joein avatar Feb 03 '24 16:02 joein

oh i see, do you want me to close the PR ?

SamirPS avatar Feb 03 '24 18:02 SamirPS

It's not necessary atm

joein avatar Feb 03 '24 18:02 joein