Quentin McGaw

chore(all): the big Sunday interfaces cleanup

1

## Changes :sun_with_face: Sunday fun / Canada Thanksgiving :tm: (also long overdued not-that-easy house cleaning) - Accept narrower interfaces (created in `interfaces.go`) - Do not import interfaces defined from other...

## Changes From Eclesio's suggested changes in #2867 Change `lib/keystore`'s `LoadKeystore` to be more 'explicit', injecting the keyring as an argument, and moving the empty account key check up in...

chore(dev): Add VSCode devcontainer definitions

1

## Changes ## Tests ## Issues ## Primary Reviewer @jimjbrettj

chore(ci): check for mocks without a go generate

1

## Changes ## Tests ## Issues ## Primary Reviewer @jimjbrettj

chore(dot/state/pruner): refactoring of code and surroundings

1

## Changes 💁 the reason is I need to fiddle with this (potentially hard) to throw out node subvalues from v1 tries ## Tests ## Issues Far shot towards #2418...

Change retain blocks type to be `uint32`

2

Since block numbers are `uint32`, retain blocks should also be `uint32`. For now we have a mix of `uint` and `int64` etc., it would be nice to change the types...

Our memory usage is too high since we keep all trie nodes in memory. Instead we should (like Substrate) store all (node hash -> node encoding) on disk, and lazy...

Our Go code (with 8582cb20a37d574e6397f980f919c6dd4dfb24a0) uses runtimes cached in the /tmp directory if available, and otherwise downloads them. Sometimes Github can be a bit flaky serving those files over http,...

dot/state/pruner: refactor code to be more understandable and modular

2

The pruner code is (unit, integration and even usage-wise) untested, and hard to understand. Since the trie lazy loading of nodes will interact a lot more with the database, and...

The header type is quite big (184 bytes) so it should be passed around as a pointer, not a value, in the block type. The alternative would be to handle...