Quentin McGaw

Results 207 issues of Quentin McGaw

## Changes ⚠️ this is just production code changes. I have most test code locally, but would like some feedback before continuing updating tests and adding more deltas for reviewers....

Status: Review Needed

## Task summary The `pkg/scale` package is cumbersome to use together with error wrapping aware code, since no sentinel error is defined and exported. All defined `errors.New(` and `fmt.Errorf(` constant...

Type: Enhancement
scale
W3F Approved

## Changes Blocked by: 1. https://github.com/libp2p/go-libp2p-kad-dht/pull/788 2. #2788 ## Tests ## Issues ## Primary Reviewer

We need to change all `int32` to `uint32` for offsets (aka pointers) and data length in `lib/runtime/imports.go` and `lib/runtime/common.go`. > Due to the use of two-complement it is hardly an...

Type: Bug
runtime
W3F Approved

## Changes Advantages: - Faster feedback since jobs are parallelised - All unit tests 'fail fast', if one matrix job fails, others are canceled Disadvantages: - we need to add...

## Describe the bug Scale decoder can go out of memory with specific input bytes, this will panic: ```go func Test_Decoder_Decode_Fail(t *testing.T) { reader := bytes.NewBuffer([]byte{0x7, 0x8, 0x9, 0x10, 0x0,...

Type: Bug
scale
p1
W3F Approved

## Changes Progress: - [ ] Version state trie operations `Put` and `Hash` - [x] Implement runtime functions - [x] `ext_trie_blake2_256_root_version_2` - [x] `ext_trie_blake2_256_ordered_root_version_2` - [x] `ext_trie_blake2_256_verify_proof_version_2` - [x] `ext_default_child_storage_root_version_2`...

## Task summary Right now, our `//go:generate mock*` comments are spread in our codebase without consistency, and usually each write the generated Go mock to a unique file. We should...

Type: Enhancement
tests
W3F Approved

## Task summary #2629 was found randomly by adding a bad test case when writing tests for the trie proofs; this should not be found randomly and we should make...

tests
W3F Approved
Type: Feature

We have **many** tests still using mockery mocks, but never calling `AssertExpectations(t)` on the mock. It means these tests pass, although the mocks are often plain wrong, and calling `AssertExpectations(t)`...

Type: Bug
tests
W3F Approved