laravel-gamify icon indicating copy to clipboard operation
laravel-gamify copied to clipboard

Make looking for badges directory recursive.

Open abetwothree opened this issue 5 years ago • 1 comments

Allows badges to be placed within other folders.

The only problem I see happening is that right now the BadgeType class does a firstOrNew to record the badge in the database solely by name. If two badges are name the same but in different folders they would over write each other. This could be avoided by adding a column to the database with the full badge namespace and doing a firstOrNew based on name and namespace.

Otherwise, this code will find badges recursively just fine.

abetwothree avatar Dec 13 '19 03:12 abetwothree

Just checking the status of this PR. Been almost 3 years hoping for this to be merged 😞

abetwothree avatar Sep 28 '22 03:09 abetwothree