add pipe ' |' (vbar) separated values option

[jobdiogenes]

Fixes #

Changes proposed in this pull request:

• add pipe | (vertical bar) separated values option to open file.

Reason:

• pipe | is used by many users and its one the best option character to separated values, because are rarely used in names or texts. And its also easy to overview when you dump the text file. One good explain about is: (https://modelingwithdata.org/pdfs/201-pdf.pdf)

@Stephen-Gates @mattRedBox

[Stephen-Gates]

Hi,

thanks for your contribution however I think more is required:

• There is no menu user interface change to accommodate the import pipe file option
• You should also consider a similar export that will need you to write an appropriate CSV dialect entry with a pipe for delimiter
• Automated tests should be provided

[jobdiogenes]

Hi,

Stehphen, thanks prompt answer.

I change only the menu interface, which pass the character value to be used load/save function. I did all tests, (open and save) and work very well. If you want can clone and build from my forke https://github.com/jobdiogenes/data-curator. Or download the Buid (linux) https://github.com/jobdiogenes/data-curator/releases/tag/1.1.1 to make the tests.

Job DIogenes

Em dom, 25 de ago de 2019 às 02:21, Stephen Gates [email protected] escreveu:

Hi,

thanks for your contribution however I think more is required:

• There is no menu user interface https://github.com/ODIQueensland/data-curator/blob/develop/src/main/menu.js change to accommodate the import pipe file option
• You should also consider a similar export that will need you to write an appropriate CSV dialect https://frictionlessdata.io/specs/csv-dialect/ entry with a pipe for delimiter
• Automated tests should be provided

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ODIQueensland/data-curator/pull/949?email_source=notifications&email_token=AAJAVLN62DXJYBH75O4HML3QGIJG3A5CNFSM4IPHBO7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5CMRLQ#issuecomment-524601518, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJAVLIVC6A6S67BK6PU4JTQGIJG3ANCNFSM4IPHBO7A .