data-curator icon indicating copy to clipboard operation
data-curator copied to clipboard

Published 20 hours ago • verified publisher icon qcif

Add Select All menu item

Open albreez opened this issue 8 years ago • 5 comments
trafficstars

Expected Behaviour (for problems)

When using the menu command: https://relishapp.com/odi-australia/data-curator/docs/edit/select-all When using the menu command, I expected it to select everything in the table as it does when using the ctrl+a keyboard shortcut.

Current Behaviour

When using the menu command, select all literally selects EVERYTHING including menu labels and the tab names. The ctrl+a keyboard shortcut works as expected.

Your Environment

  • Data Curator version 0.2.3
  • Windows 7

albreez avatar Sep 18 '17 03:09 albreez

See 1.2 at https://blog.avocode.com/blog/4-must-know-tips-for-building-cross-platform-electron-apps for a potential resolution

Stephen-Gates avatar Sep 19 '17 14:09 Stephen-Gates

I have temporarily disabled the menu item in https://github.com/ODIQueensland/data-curator/commit/f6eb0fb8d8ba8eb3821cadf3f76f7bc3defcb6e4 so it's not a problem in the Beta. Will fix in future release.

Stephen-Gates avatar Sep 21 '17 06:09 Stephen-Gates

This behaviour seems to be due to using

role: 'selectall'

when you use

label: 'Select All', accelerator: 'CmdOrCtrl+A'

the selecting of ui components doesn't occur https://github.com/ODIQueensland/data-curator/commit/71cae21df3a27a5a6f09fb6517a434b282c2a0a4

Stephen-Gates avatar Sep 22 '17 23:09 Stephen-Gates

Command + A works to select all in 0.5.4. Menu item removed. Should put back and get working at some stage.

Stephen-Gates avatar Nov 29 '17 20:11 Stephen-Gates

Updated acceptance test

Stephen-Gates avatar Apr 28 '18 01:04 Stephen-Gates