data-curator icon indicating copy to clipboard operation
data-curator copied to clipboard

Review replacing zip functions with Frictionless Data libraries

Open Stephen-Gates opened this issue 7 years ago • 1 comments

Desired Behaviour

Zip features have been added to datapackage.js. We should test, review and replace our existing code with this if it makes sense.

Stephen-Gates avatar Jan 24 '18 20:01 Stephen-Gates

Comment from Matt...

I haven't looked at changes yet, but there could be advantages to using the new code]:

  1. Even though we've done the work here, it was a bit of effort finding a good library that had an easy to use interface for both - and of course there's always the issue that perhaps one library might lose support and we'll have to choose another - I use a different library for load and save.
  2. I did have a minor issue where I wondered what the standard is for zipping and unzipping with/without a parent folder
    • should a parent folder be included in the zip?
    • should the unzip expect a parent folder or just handle the case that 1 might be there (e.g., keep descending recursively til it finds the location with schema.json)
  3. Our code just does the min necessary for this unzipping/zipping - there might be some future edge case that perhaps we're not handling properly yet.

If frictionless are handling these questions for us, it might make it better in long term (even though it's a little more work to unpin what we've done and use their library instead) - it does take any potential future burden for this off our hands.

Stephen-Gates avatar Jan 26 '18 07:01 Stephen-Gates